docs(readme): fix @opentelemetry/instrumentation-http link#1973
Merged
dyladan merged 2 commits intoopen-telemetry:mainfrom Mar 1, 2021
Merged
docs(readme): fix @opentelemetry/instrumentation-http link#1973dyladan merged 2 commits intoopen-telemetry:mainfrom
dyladan merged 2 commits intoopen-telemetry:mainfrom
Conversation
hongbo-miao
requested review from
Flarna,
OlivierAlbertini,
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1973 +/- ##
==========================================
- Coverage 92.90% 92.78% -0.13%
==========================================
Files 152 147 -5
Lines 5922 5698 -224
Branches 1245 1193 -52
==========================================
- Hits 5502 5287 -215
+ Misses 420 411 -9 |
Flarna
approved these changes
Feb 26, 2021
dyladan
approved these changes
Mar 1, 2021
johnbley
approved these changes
Mar 1, 2021
This was referenced Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@opentelemetry/instrumentation-httpwas pointing to old plugin link.@opentelemetry/instrumentation-httpsbecause new@opentelemetry/instrumentation-httpwill handle both HTTP and HTTPs, so remove that not used link.